minor cleanups. (#820)

empty statements, unreachable code, member funct can be const.

diff --git a/gui/processwait.h b/gui/processwait.h
index 334e8e54daf4f1d1783135784eca5169a2de976c..f13f7dc0d6d093dfb00d401dc0f325b0e9ef56f4 100644 (file)
--- a/gui/processwait.h
+++ b/gui/processwait.h
@@ -45,7 +45,7 @@ class ProcessWaitDialog: public QDialog
 public:
   ProcessWaitDialog(QWidget* parent, QProcess* process);
 
-  QString getOutputString()
+  QString getOutputString() const
   {
     return QString::fromLocal8Bit(outputString_);
   }

diff --git a/gui/runmachine.cc b/gui/runmachine.cc
index 6bc3eceb0442fca670003b60d2f40f5694177b96..80465a5c60547024621e1fc5e18884022244082d 100644 (file)
--- a/gui/runmachine.cc
+++ b/gui/runmachine.cc
@@ -33,19 +33,14 @@ QString RunMachine::decodeProcessError(QProcess::ProcessError err)
   switch (err) {
   case QProcess::FailedToStart:
     return tr("Process failed to start");
-    break;
   case QProcess::Crashed:
     return tr("Process crashed");
-    break;
   case QProcess::Timedout:
     return tr("Process timedout");
-    break;
   case QProcess::WriteError:
     return tr("Error while trying to write to process");
-    break;
   case QProcess::ReadError:
     return tr("Error while trying to read from process");
-    break;
   case QProcess::UnknownError:
   default:
     return tr("Unknown process error");
@@ -141,7 +136,7 @@ void RunMachine::execute(SignalId id,
         qDebug() << "signal" << id << "UNEXPECTED in init state!";
       }
       break;
-    };
+    }
     break;
 
   case starting:
@@ -161,7 +156,7 @@ void RunMachine::execute(SignalId id,
         qDebug() << "signal" << id << "UNEXPECTED in starting state!";
       }
       break;
-    };
+    }
     break;
 
   case running:
@@ -209,7 +204,7 @@ void RunMachine::execute(SignalId id,
         qDebug() << "signal" << id << "UNEXPECTED in running state!";
       }
       break;
-    };
+    }
     break;
 
   case done:
@@ -220,7 +215,7 @@ void RunMachine::execute(SignalId id,
       qDebug() << "UNEXPECTED State!";
     }
     break;
-  };
+  }
   if constexpr(debug) {
     qDebug() << "exec leaving" << state_ << id;
   }

diff --git a/gui/runmachine.h b/gui/runmachine.h
index 0c5da6371f23fee8f7399f2ced2c4378017a265c..ff3104b5278f4d86a780740d3f755482a99082fc 100644 (file)
--- a/gui/runmachine.h
+++ b/gui/runmachine.h
@@ -65,11 +65,11 @@ public:
   static QString decodeProcessError(QProcess::ProcessError err);
   int exec();
   void open();
-  QString getOutputString()
+  QString getOutputString() const
   {
     return progress_->getOutputString();
   }
-  QString getErrorString()
+  QString getErrorString() const
   {
     return errorString_;
   }